001//////////////////////////////////////////////////////////////////////////////// 002// checkstyle: Checks Java source code for adherence to a set of rules. 003// Copyright (C) 2001-2017 the original author or authors. 004// 005// This library is free software; you can redistribute it and/or 006// modify it under the terms of the GNU Lesser General Public 007// License as published by the Free Software Foundation; either 008// version 2.1 of the License, or (at your option) any later version. 009// 010// This library is distributed in the hope that it will be useful, 011// but WITHOUT ANY WARRANTY; without even the implied warranty of 012// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 013// Lesser General Public License for more details. 014// 015// You should have received a copy of the GNU Lesser General Public 016// License along with this library; if not, write to the Free Software 017// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA 018//////////////////////////////////////////////////////////////////////////////// 019 020package com.puppycrawl.tools.checkstyle.checks.imports; 021 022import java.util.HashSet; 023import java.util.Set; 024 025import com.puppycrawl.tools.checkstyle.api.AbstractCheck; 026import com.puppycrawl.tools.checkstyle.api.DetailAST; 027import com.puppycrawl.tools.checkstyle.api.FullIdent; 028import com.puppycrawl.tools.checkstyle.api.TokenTypes; 029 030/** 031 * <p> 032 * Checks for imports that are redundant. An import statement is 033 * considered redundant if: 034 * </p> 035 *<ul> 036 * <li>It is a duplicate of another import. This is, when a class is imported 037 * more than once.</li> 038 * <li>The class non-statically imported is from the {@code java.lang} 039 * package. For example importing {@code java.lang.String}.</li> 040 * <li>The class non-statically imported is from the same package as the 041 * current package.</li> 042 *</ul> 043 * <p> 044 * An example of how to configure the check is: 045 * </p> 046 * <pre> 047 * <module name="RedundantImport"/> 048 * </pre> 049 * Compatible with Java 1.5 source. 050 * 051 * @author Oliver Burn 052 */ 053public class RedundantImportCheck 054 extends AbstractCheck { 055 056 /** 057 * A key is pointing to the warning message text in "messages.properties" 058 * file. 059 */ 060 public static final String MSG_LANG = "import.lang"; 061 062 /** 063 * A key is pointing to the warning message text in "messages.properties" 064 * file. 065 */ 066 public static final String MSG_SAME = "import.same"; 067 068 /** 069 * A key is pointing to the warning message text in "messages.properties" 070 * file. 071 */ 072 public static final String MSG_DUPLICATE = "import.duplicate"; 073 074 /** Set of the imports. */ 075 private final Set<FullIdent> imports = new HashSet<>(); 076 /** Set of static imports. */ 077 private final Set<FullIdent> staticImports = new HashSet<>(); 078 079 /** Name of package in file. */ 080 private String pkgName; 081 082 @Override 083 public void beginTree(DetailAST aRootAST) { 084 pkgName = null; 085 imports.clear(); 086 staticImports.clear(); 087 } 088 089 @Override 090 public int[] getDefaultTokens() { 091 return getAcceptableTokens(); 092 } 093 094 @Override 095 public int[] getAcceptableTokens() { 096 return new int[] 097 {TokenTypes.IMPORT, 098 TokenTypes.STATIC_IMPORT, 099 TokenTypes.PACKAGE_DEF, }; 100 } 101 102 @Override 103 public int[] getRequiredTokens() { 104 return getAcceptableTokens(); 105 } 106 107 @Override 108 public void visitToken(DetailAST ast) { 109 if (ast.getType() == TokenTypes.PACKAGE_DEF) { 110 pkgName = FullIdent.createFullIdent( 111 ast.getLastChild().getPreviousSibling()).getText(); 112 } 113 else if (ast.getType() == TokenTypes.IMPORT) { 114 final FullIdent imp = FullIdent.createFullIdentBelow(ast); 115 if (isFromPackage(imp.getText(), "java.lang")) { 116 log(ast.getLineNo(), ast.getColumnNo(), MSG_LANG, 117 imp.getText()); 118 } 119 // imports from unnamed package are not allowed, 120 // so we are checking SAME rule only for named packages 121 else if (pkgName != null && isFromPackage(imp.getText(), pkgName)) { 122 log(ast.getLineNo(), ast.getColumnNo(), MSG_SAME, 123 imp.getText()); 124 } 125 // Check for a duplicate import 126 imports.stream().filter(full -> imp.getText().equals(full.getText())) 127 .forEach(full -> log(ast.getLineNo(), ast.getColumnNo(), 128 MSG_DUPLICATE, full.getLineNo(), 129 imp.getText())); 130 131 imports.add(imp); 132 } 133 else { 134 // Check for a duplicate static import 135 final FullIdent imp = 136 FullIdent.createFullIdent( 137 ast.getLastChild().getPreviousSibling()); 138 staticImports.stream().filter(full -> imp.getText().equals(full.getText())) 139 .forEach(full -> log(ast.getLineNo(), ast.getColumnNo(), 140 MSG_DUPLICATE, full.getLineNo(), imp.getText())); 141 142 staticImports.add(imp); 143 } 144 } 145 146 /** 147 * Determines if an import statement is for types from a specified package. 148 * @param importName the import name 149 * @param pkg the package name 150 * @return whether from the package 151 */ 152 private static boolean isFromPackage(String importName, String pkg) { 153 // imports from unnamed package are not allowed: 154 // http://docs.oracle.com/javase/specs/jls/se7/html/jls-7.html#jls-7.5 155 // So '.' must be present in member name and we are not checking for it 156 final int index = importName.lastIndexOf('.'); 157 final String front = importName.substring(0, index); 158 return front.equals(pkg); 159 } 160}